Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sprint
Export Multiple Visualizations 🗂️- Will & Justin #55
Who worked on this sprint?
Will and Justin
Who did what on this sprint?
Worked together
Features Implemented
Exporting multiple visualizations at once,
keeping track of stored visualizations in a cart,
maintaining cart storage throughout a session
New files created
/components/ui/hover-card.tsx
/components/Cart.tsx
Existing files modified
/app/graph/page.tsx
/app/lib/export-to-pdf.ts
Acceptance Criteria
Users can download several visualizations into a single PDF from the browser - Done
Visualizations (or rather their equivalent base64 strings) are stored in session storage to allow cart persistence between refreshes - Done
UI matches Figma exactly - Done, minor discrepancies in font on PDF
Code runs locally without errors and builds successfully
Merge via PR
Testing: how did you test?
Downloading many graphs while incrementally changing
Tested cart component using localhost and isolating various functions such as clearing cart and deleting entries
Features Not Implemented/Incomplete
None
Bugs Discovered
Deleting duplicate entries is buggy because it is based on index of the entry name in the list of filter names
Screenshots:
https://github.com/user-attachments/assets/5fcff905-ccf3-442c-9c24-8c393fcb095a
Tag Dan and Shayne
@danglorioso @shaynesidman