Add heap sized based full gc heuristic #60376
Open
+29
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbaraldi
force-pushed
the
gb/heuristic
branch
from
7e96c12 to
8920d9c
Compare
vtjnash
reviewed
Dec 15, 2025
src/gc-stock.c
Outdated
| } | ||
| else { | ||
| ptls->gc_tls.gc_cache.scanned_bytes += nb; | ||
| size_t nb = jl_genericmemory_nbytes(m); |
gbaraldi
force-pushed
the
gb/heuristic
branch
from
7da9163 to
fe564b4
Compare
gbaraldi
added
backport 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #50658 (comment)
This shouldn't ever trigger on normal Julia code, but might help when the gc counted malloc functions are used too much.
Also cleaned up the logic that was used for promoted_bytes. Trying to infer from the old bytes marked was unreliable. What actually matters is how many new objects we've seen