fix: Specialized ReshapedArray dispatch to resolve setindex! ambiguities #680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #587
Summary
Resolves
setindex!method ambiguities occurring when usingReshapedArrayviews of GPU-backed arrays.Issue
The ambiguity was caused by a dispatch tie between the general
WrappedGPUArrayunion method and the specializedReshapedArrayconstructor. This PR breaks that tie by providing specialized_unsafe_setindex!methods forIndexLinearandIndexCartesian.By specifying the concrete
IndexStylesubtypes, these methods provide a narrower dispatch scope, ensuring Julia selects the correct vectorized path for reshaped views.Changes
ReshapedArrayto resolve ambiguities.Verification
MethodErrorin the reported minimal working example.compare().indexing combinatorialtest suite onROCArrayandJLArray.