debug: InternalModel with TrapezoidalCollocation now works#321
Merged
franckgaga merged 5 commits intomainfrom Feb 23, 2026
Merged
debug: InternalModel with TrapezoidalCollocation now works#321franckgaga merged 5 commits intomainfrom
InternalModel with TrapezoidalCollocation now works#321franckgaga merged 5 commits intomainfrom
Conversation
The state vector is not augmented for `InternalModel`. The `TrapezoidalCollcation` nonlinear equality constraint method was crashing since `nx̂=nx`. In the long term I should handle the stochastic state defects as linear equality constraint. It will simplify the implementation of the nonlinear equality constraint methods, and it is potentially cheaper.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
==========================================
+ Coverage 98.38% 98.42% +0.03%
==========================================
Files 29 29
Lines 5389 5397 +8
==========================================
+ Hits 5302 5312 +10
+ Misses 87 85 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@JuliaRegistrator register |
|
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was crashing before this PR. The test with
TapezoidalCollcationnow useInternalModel.This is a quick fix but in the long run I should treat the defect of the stochastic state as linear equality constraints:
CollocationMethod