Skip to content

Comments

debug: InternalModel with TrapezoidalCollocation now works#321

Merged
franckgaga merged 5 commits intomainfrom
debug_imc_colloc
Feb 23, 2026
Merged

debug: InternalModel with TrapezoidalCollocation now works#321
franckgaga merged 5 commits intomainfrom
debug_imc_colloc

Conversation

@franckgaga
Copy link
Member

@franckgaga franckgaga commented Feb 23, 2026

It was crashing before this PR. The test with TapezoidalCollcation now use InternalModel.

This is a quick fix but in the long run I should treat the defect of the stochastic state as linear equality constraints:

  1. It will simplify the implementation of the nonlinear equality constraint methods for all CollocationMethod
  2. It will me presumably cheaper.

The state vector is not augmented for `InternalModel`. The `TrapezoidalCollcation` nonlinear equality constraint method was crashing since `nx̂=nx`.

In the long term I should handle the stochastic state defects as linear equality constraint. It will simplify the implementation of the nonlinear equality constraint methods, and it is potentially cheaper.
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.42%. Comparing base (bf93872) to head (4c35776).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   98.38%   98.42%   +0.03%     
==========================================
  Files          29       29              
  Lines        5389     5397       +8     
==========================================
+ Hits         5302     5312      +10     
+ Misses         87       85       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@franckgaga franckgaga merged commit 4ab5d3b into main Feb 23, 2026
5 checks passed
@franckgaga franckgaga deleted the debug_imc_colloc branch February 23, 2026 23:41
@franckgaga
Copy link
Member Author

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants