Script to respond to comments in PRs#279
Merged
mfalt merged 3 commits intoJuliaControl:masterfrom Apr 7, 2020
Merged
Conversation
Member
Author
|
I think this should be ready now @baggepinnen , updated the existing script to not report failure when the PR is created from a fork. In that case the script would previously fail because it is "dangerous" to let forks access to the login for the JuliaControlBot. Now instead of failing it skips the step. We can use the feature in this PR of commenting on PRs from forks instead to run the script "manually". |
mfalt
commented
Apr 2, 2020
| --data '{"event_type": "prupdate", "client_payload": { "repository": "'"$GITHUB_REPOSITORY"'", "pr_number": ${{ github.event.number }} }}' | ||
| fi | ||
| env: | ||
| SECRET: ${{ secrets.ACCESS_TOKEN_BOT }} |
Member
Author
There was a problem hiding this comment.
This is to avoid weird issue of environment variables not being directly available in if statements.
Member
Author
|
Aby objections to pulling this @baggepinnen ? |
Member
|
Go ahead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks any comments on PRs for the string
@JuliaControlBot test-plotsand if the user is an admin, then pings ControlExamplePlots.jl to do tests and respond with a comment.See corresponding script here: https://github.com/mfalt/ControlSystems.jl/blob/master/.github/workflows/CommentResponder.yml
which is triggered here:
mfalt#3