feat: joinpoint separate mod #353
Conversation
| var server = senderPlayer.getEntityWorld().getServer(); | ||
| var apis = server.getApiServices(); | ||
| var userCache = apis.nameToIdCache(); | ||
|
|
||
| // player to owned joinpoints | ||
| // player to accessible joinpoints |
There was a problem hiding this comment.
this was me brainstorming, remove
| private static final JoinpointsConfig config = new JoinpointsConfig( | ||
| Path.of("./config/joinpoints.properties"), | ||
| "Joinpoints Configuration", | ||
| "https://github.com/John-Paul-R/Essential-Commands" // TODO: Update with joinpoints docs link |
There was a problem hiding this comment.
(though consider merging configs)
There was a problem hiding this comment.
(though, this being "part of ec" may be a distinctly "me" thing -- whatever's decided, I should be consistent in the messaging: Is this a plugin for EC, or an entirely separate mod [that has a hard dependency]? -- is my ideal world one where the shared bits are a lib? how much really needs to be shared?)
| private JoinpointsCommandRegistry() {} | ||
|
|
||
| public static void register() { | ||
| CommandRegistrationCallback.EVENT.register((dispatcher, registryAccess, environment) -> { |
There was a problem hiding this comment.
we should consider registering on the EC root node, and also supporting excluded_top_level_commands
| // Ensure EC projects are evaluated and built before joinpoints configuration | ||
| // This is needed because modLocalRuntime needs the jars to exist | ||
| evaluationDependsOnChildren() | ||
| project.evaluationDependsOn(':') | ||
| project.evaluationDependsOn(':ec-core') |
There was a problem hiding this comment.
ensure this sorcery is still necessary, I think the sorcery in dependencies is doing the heavy lifting rn
…et serialization seems to be gone for some reason
No description provided.