Refactor: Removed CachedVisibilityMap to use previous frame data, fixed another crash.#3
Draft
Jaskowicz1 wants to merge 5 commits intomainfrom
Draft
Refactor: Removed CachedVisibilityMap to use previous frame data, fixed another crash.#3Jaskowicz1 wants to merge 5 commits intomainfrom
Jaskowicz1 wants to merge 5 commits intomainfrom
Conversation
Owner
Author
|
Draft PR whilst I work out why the crash exists. |
Jaskowicz1
commented
Feb 13, 2025
Owner
Author
Owner
Author
|
Whilst people could in theory make all their static meshes change to support this and whatnot, it'll increase RAM but decrease VRAM. This may be fine tbh (especially for platforms that have shared RAM because you're not actually losing anything, it's just now in a different place). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR removes the CachedVisibilityMap to use the previous frame's data to check if objects should still be occluded or not.
This saves, at a minimum, 188 bytes of memory. In a scene with 1000 objects (this is quite easy to hit, reminder, each Static Mesh inside of a blueprint is another object), this is roughly ((9*1000)+188)=9188 bytes (9.1KBs) of memory (9 is the size of FPrimitiveSceneID + bool), actual saved memory might be smaller or bigger, depends on usage.
This PR also stops sending every object in the FrameResult's VisibilityMap to the GameThread if it hasn't changed. This improves the frame time quite a lot in a heavy populated world (I've seen about a ~0.2-0.4ms improvement in my test scene), as we no longer send a task for every object in the world, only ones that need to be occluded (and if their visibility doesn't match what the occluder wants).
Closes #1