Refactor: Move API logic to handlers

[Its4Nik]

@sourcery-ai

Summary by Sourcery

Move API logic into a dedicated handlers layer, centralize WebSocket broadcasting, reorganize project structure for better modularity, and enhance scheduler, plugin loading, and database initialization.

New Features:

• Introduce structured handler classes for all API endpoints (config, stacks, docker, logs, store, themes, database, health)
• Implement a unified WebSocket broadcast server for streaming Docker stats, application logs, and stack events
• Expand database schema with themes and store_repos tables and seed default values

Enhancements:

• Refactor scheduler logic to use a reusable scheduledJob loop instead of setInterval
• Replace all postToClient calls in stack operations with a unified broadcast function
• Enhance PluginManager to dynamically load plugins on start and report plugin version
• Decouple server initialization from index.ts by centralizing startup in a Starter class
• Clean up package.json dependencies and update TypeScript config for bundler resolution and path aliases
• Adjust docker-compose.dev settings for restart policy and mount paths
• Standardize error handling across database backup/restore and utility functions

[sourcery-ai]

Reviewer's Guide

This PR refactors the API by extracting routing and logic into dedicated handler classes, replacing the previous Elysia server setup with a unified handlers export; implements a generic WebSocket broadcasting layer for logs, stack events, and Docker stats; refactors the core scheduler to use a reusable job loop; enhances plugin management with asynchronous startup and consolidated reporting; expands the database schema to include store repositories and themes (while removing API key storage); cleans up dependencies and configuration; and strengthens error handling and data validation throughout backup, restore, and stats operations.

Sequence diagram for WebSocket broadcast of stack events

sequenceDiagram
    participant StackHandler
    participant Controller as StackController
    participant Broadcast as broadcast (WebSocket)
    participant Client
    StackHandler->>Controller: deployStack(config)
    Controller->>Broadcast: broadcast({topic: "stack", data: {...}})
    Broadcast-->>Client: WebSocket message (stack event)
    Note over Client: Client receives stack status/progress/error

Loading

Sequence diagram for unified handler invocation

sequenceDiagram
    actor User
    participant App as Application
    participant Handlers as handlers/index.ts
    participant ApiHandler
    User->>App: API request (e.g. updateConfig)
    App->>Handlers: handlers.ApiHandler.updateConfig(...)
    Handlers->>ApiHandler: updateConfig(...)
    ApiHandler-->>Handlers: result
    Handlers-->>App: result
    App-->>User: response

Loading

ER diagram for updated database schema (config, store_repos, themes)

erDiagram
    CONFIG {
        NUMBER keep_data_for
        NUMBER fetching_interval
    }
    STORE_REPOS {
        TEXT slug
        TEXT base
    }
    THEMES {
        TEXT name PK
        TEXT creator
        TEXT vars
        TEXT tags
    }

Loading

File-Level Changes

Change	Details	Files
Centralize API routing and logic into handler classes	Replaced Elysia server setup in src/index.ts with default handlers export Moved route definitions into src/handlers as classes (config, stacks, docker, logs, store, themes) Added Starter module to orchestrate scheduler, plugin startup, and WebSocket server	src/index.ts src/handlers/index.ts src/handlers/config.ts src/handlers/stacks.ts src/handlers/docker.ts src/handlers/logs.ts src/handlers/store.ts src/handlers/themes.ts src/handlers/modules/starter.ts
Introduce generic WebSocket broadcast layer	Added broadcast utility and WSServer in handlers/modules/docker-socket.ts Unified log and stack stream modules using PassThrough in handlers/modules/logs-socket.ts and live-stacks.ts Updated core stacks controller and runStackCommand to use broadcast instead of postToClient	src/handlers/modules/docker-socket.ts src/handlers/modules/logs-socket.ts src/handlers/modules/live-stacks.ts src/core/stacks/controller.ts src/core/stacks/operations/runStackCommand.ts
Refactor core scheduler to reusable job loop	Replaced setInterval with scheduledJob loop handling timing and errors Centralized task logging and delay calculation in scheduledJob	src/core/docker/scheduler.ts
Enhance plugin manager for async startup and reporting	Added async start() to initialize plugins before server start Consolidated active and failed plugin info (including version) in getPlugins Adjusted loader to supply default version on failure	src/core/plugins/plugin-manager.ts src/core/plugins/loader.ts
Expand database schema and store repository support	Added store_repos and themes tables (with default seeds) and removed api_key column Created stores and themes modules under core/database with CRUD operations Updated database index exports to include new store and theme functions	src/core/database/database.ts src/core/database/config.ts src/core/database/stores.ts src/core/database/themes.ts src/core/database/index.ts
Clean up dependencies and configuration	Removed Elysia, CORS, Swagger, static, and other unused packages from package.json Updated tsconfig with bundler resolution and new path mappings Pruned outdated middleware/routes and refreshed dependency-graph files	package.json tsconfig.json dependency-graph.mmd dependency-graph.svg
Improve error handling and data validation	Wrapped non-Error exceptions in backup and restore operations as Error instances Strengthened type validation in addContainerStats signature and usage Adjusted updateConfig to remove api_key parameter and enforce types	src/core/database/backup.ts src/core/database/containerStats.ts

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[Its4Nik]

@sourcery-ai review

[Its4Nik]

@sourcery-ai review

[sourcery-ai]

Hey @Its4Nik - I've reviewed your changes - here's some feedback:

• Avoid performing heavy startup tasks (like scheduling jobs and launching the WebSocket server) as side-effects during module imports in handlers/index.ts; decouple initialization into an explicit start function so the entry point controls when and how the system comes up.
• Standardize error handling by preserving original Error instances instead of wrapping everything in new Error(error as string), which strips stack traces and context—consider rethrowing or using cause to retain full error information.
• Remove hard-coded plugin paths in PluginManager.start (e.g. './server/src/plugins') and make the plugin directory configurable or aligned with the actual project layout to prevent path mismatches during startup.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- Avoid performing heavy startup tasks (like scheduling jobs and launching the WebSocket server) as side-effects during module imports in handlers/index.ts; decouple initialization into an explicit start function so the entry point controls when and how the system comes up.
- Standardize error handling by preserving original Error instances instead of wrapping everything in `new Error(error as string)`, which strips stack traces and context—consider rethrowing or using `cause` to retain full error information.
- Remove hard-coded plugin paths in PluginManager.start (e.g. './server/src/plugins') and make the plugin directory configurable or aligned with the actual project layout to prevent path mismatches during startup.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (code-quality): Avoid loops with missing or constant end conditions. (avoid-infinite-loops)

Explanation

Loops with a constant condition, or no terminator, can be useful in certain contexts, but it's easy to forget to break out of them. This rule highlights loops which may never end.

[Its4Nik]

@sourcery-ai issue

[sourcery-ai]

I have created an issue for your comment: #52