create new method in Chars2Vec class#10
Open
buiminhhien2k wants to merge 1 commit intoIntuitionEngineeringTeam:masterfrom
Open
create new method in Chars2Vec class#10buiminhhien2k wants to merge 1 commit intoIntuitionEngineeringTeam:masterfrom
buiminhhien2k wants to merge 1 commit intoIntuitionEngineeringTeam:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think there is some part of the Chars2Vec can be optimized with the new method "featuring_word".
I also create a new method call "check_similarity" to check the similarity of the 2 words input using the self.model param