Extend nan_to_num with broadcast support of nan, posinf, and neginf#2754
Merged
antonwolfy merged 4 commits intomasterfrom Feb 9, 2026
Merged
Extend nan_to_num with broadcast support of nan, posinf, and neginf#2754antonwolfy merged 4 commits intomasterfrom
nan_to_num with broadcast support of nan, posinf, and neginf#2754antonwolfy merged 4 commits intomasterfrom
Conversation
antonwolfy
changed the title
nan_to_num implementation with broadcast support of nan, posinf, and neginfnan_to_num with broadcast support of nan, posinf, and neginf
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev2=py313h509198e_19 ran successfully. |
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Collaborator
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
vlad-perevezentsev
approved these changes
Feb 9, 2026
Contributor
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
LGTM
Than you @antonwolfy !
antonwolfy
force-pushed
the
nan-to-num-broadcasting
branch
from
32c1e07 to
1b72e9c
Compare
github-actions bot
added a commit
that referenced
this pull request
Feb 9, 2026
…eginf` (#2754) The PR extends implementation of `dpnp.nan_to_num` function to align with NumPy and CuPy which supports `nan`, `posinf`, and `neginf` keywords as any array through broadcasting. This PR adds handling for a common path where at least one of the keywords has non-scalar value. The path does not assume a dedicated SYCL kernel, instead proposes to rely on implementation through existing python functions. That can be improved in the future if required. 06a74cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR extends implementation of
dpnp.nan_to_numfunction to align with NumPy and CuPy which supportsnan,posinf, andneginfkeywords as any array through broadcasting.This PR adds handling for a common path where at least one of the keywords has non-scalar value.
The path does not assume a dedicated SYCL kernel, instead proposes to rely on implementation through existing python functions. That can be improved in the future if required.