Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 18, 2025

Predicate-based conditions were not marking their target variables as observed, leaving convergence checks to fragile codegen heuristics.

  • Observer analysis: Track the last assigned variable per scope, reuse a shared predicate set, and recursively detect predicates to mark the correct variable as observed.
  • Cleanup: Remove redundant identifier predicate branch for clarity.
  • Tests: Add compiler test ensuring loop while not converged produces a call to eigen_check_converged.

Example:

x is 0
loop while not converged:
    x is x + 1  # now marked observed; codegen emits eigen_check_converged
Original prompt

Look for areas of improvement


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits December 19, 2025 00:01
Co-authored-by: InauguralPhysicist <217690737+InauguralPhysicist@users.noreply.github.com>
Co-authored-by: InauguralPhysicist <217690737+InauguralPhysicist@users.noreply.github.com>
Copilot AI changed the title [WIP] Identify areas of improvement in project Improve predicate observation handling for convergence checks Dec 19, 2025
@InauguralPhysicist InauguralPhysicist marked this pull request as ready for review December 19, 2025 00:10
@InauguralPhysicist InauguralPhysicist merged commit 4b76388 into main Dec 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants