Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 24, 2025

The CI workflow was running flake8 with --exit-zero, silently ignoring all violations (270 accumulated).

Changes

  • .github/workflows/ci.yml: Removed --exit-zero flag so flake8 violations now fail builds
  • .flake8: Added configuration with per-file ignores for existing violations to prevent breaking changes while catching new issues
    • 88-char line length matching black
    • Documents existing tech debt (star imports, unused variables, complexity, etc.)
  • FLAKE8_ENFORCEMENT.md: Documents violation categories and cleanup roadmap

Result

New code quality violations will fail CI. Existing code unchanged via per-file ignores. Tech debt can be addressed incrementally.

- flake8 src/ tests/ --count --exit-zero --max-complexity=10 --max-line-length=88 --statistics
+ flake8 src/ tests/
Original prompt

Why arent we running flak8 ? I have a bad feeling


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits November 24, 2025 03:48
Co-authored-by: InauguralPhysicist <217690737+InauguralPhysicist@users.noreply.github.com>
Co-authored-by: InauguralPhysicist <217690737+InauguralPhysicist@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix flake8 configuration for code quality checks Enable flake8 enforcement in CI Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants