Skip to content

fix(tooltip/snackbar): use overlay service size helpers - master#16837

Open
RivaIvanova wants to merge 9 commits intomasterfrom
rivanova/fix-16458-master
Open

fix(tooltip/snackbar): use overlay service size helpers - master#16837
RivaIvanova wants to merge 9 commits intomasterfrom
rivanova/fix-16458-master

Conversation

@RivaIvanova
Copy link
Member

Closes #16458

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

This comment was marked as outdated.

@RivaIvanova RivaIvanova added the ❌ status: awaiting-test PRs awaiting manual verification label Jan 30, 2026
@RivaIvanova RivaIvanova changed the title fix(overlay): conditionally cache element size fix(overlay): conditionally cache element size - master Jan 30, 2026
@RivaIvanova RivaIvanova requested a review from wnvko January 30, 2026 16:33
Copy link
Contributor

@wnvko wnvko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we know this PR is breaking the tooltip. What is the reason this happening? Can we revert the change that made this happen?
Adding this additional property to the overlay settings and use it in this way in the tooltip looks like a breaking change. IMO it will be better to find out what happened in the above mentioned PR and to revert it.

@RivaIvanova RivaIvanova added 🛠️ status: in-development Issues and PRs with active development on them and removed ❌ status: awaiting-test PRs awaiting manual verification labels Feb 4, 2026
@RivaIvanova RivaIvanova changed the title fix(overlay): conditionally cache element size - master fix(tooltip/snackbar): use overlay service size helpers - master Feb 6, 2026
@RivaIvanova RivaIvanova requested a review from Copilot February 6, 2026 14:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tooltip/Snackbar]: overlay content size is not properly reflected when component is placed inside another element

2 participants