Skip to content

Fix ARIA grid structure violations for WCAG 1.3.1 compliance #16823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Fix ARIA grid structure violations for WCAG 1.3.1 compliance #16823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c0b9fd
Initial plan
Copilot Jan 29, 2026
a68cd61
Initial exploration - understanding accessibility issue
Copilot Jan 29, 2026
86b36f5
Fix ARIA accessibility violations in grid components
Copilot Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 30 additions & 10 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions projects/igniteui-angular/grids/core/src/grouping/grid-group-by-area.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {
Component,
HostBinding,
Input,
} from '@angular/core';
import { IChipsAreaReorderEventArgs, IgxChipComponent, IgxChipsAreaComponent } from 'igniteui-angular/chips';
Expand All @@ -24,6 +25,13 @@ import { IGroupingExpression, ISortingExpression } from 'igniteui-angular/core';
imports: [IgxChipsAreaComponent, IgxChipComponent, IgxIconComponent, IgxSuffixDirective, IgxGroupAreaDropDirective, IgxDropDirective, NgTemplateOutlet, IgxGroupByMetaPipe]
})
export class IgxGridGroupByAreaComponent extends IgxGroupByAreaDirective {
/**
* @hidden
* @internal
*/
@HostBinding('attr.role')
public role = 'presentation';

@Input()
public sortingExpressions: ISortingExpression[] = [];

Expand Down
2 changes: 1 addition & 1 deletion projects/igniteui-angular/grids/core/src/headers/grid-header-row.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div role="rowgroup" class="igx-grid-thead__wrapper" (scroll)="scroll($event)" [style.width.px]="width"
<div class="igx-grid-thead__wrapper" (scroll)="scroll($event)" [style.width.px]="width"
[class.igx-grid__tr--mrl]="hasMRL">

<!-- Column headers area -->
Expand Down
6 changes: 6 additions & 0 deletions projects/igniteui-angular/grids/core/src/headers/grid-header-row.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ export class IgxGridHeaderRowComponent implements DoCheck {
@Input()
public unpinnedColumnCollection: ColumnType[] = [];

/**
* @hidden @internal
*/
@HostBinding('attr.role')
public role = 'rowgroup';

@HostBinding('attr.aria-activedescendant')
public get activeDescendant() {
const activeElem = this.navigation.activeNode;
Expand Down
7 changes: 7 additions & 0 deletions projects/igniteui-angular/grids/core/src/toolbar/grid-toolbar.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,13 @@ export class IgxGridToolbarComponent implements OnDestroy {
@HostBinding('class.igx-grid-toolbar')
public defaultStyle = true;

/**
* @hidden
* @internal
*/
@HostBinding('attr.role')
public role = 'presentation';

protected _grid: GridType;
protected sub: Subscription;

Expand Down
4 changes: 2 additions & 2 deletions projects/igniteui-angular/grids/grid/src/grid.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@
</div>
</div>

<div class="igx-grid__scroll" [style.height.px]="scrollSize" #scr [hidden]="isHorizontalScrollHidden" (pointerdown)="$event.preventDefault()">
<div class="igx-grid__scroll" role="presentation" [style.height.px]="scrollSize" #scr [hidden]="isHorizontalScrollHidden" (pointerdown)="$event.preventDefault()">
<div class="igx-grid__scroll-start" [style.width.px]="pinnedStartWidth" [style.min-width.px]="pinnedStartWidth"></div>
<div class="igx-grid__scroll-main" [style.width.px]="unpinnedWidth">
<ng-template igxGridFor [igxGridForOf]="EMPTY_DATA" #scrollContainer>
Expand All @@ -208,7 +208,7 @@
<div class="igx-grid__scroll-end" [style.float]="'right'" [style.width.px]="pinnedEndWidth" [style.min-width.px]="pinnedEndWidth" [hidden]="pinnedEndWidth === 0"></div>
</div>

<div class="igx-grid__footer" #footer>
<div class="igx-grid__footer" role="presentation" #footer>
<ng-content select="igx-grid-footer,igc-grid-footer"></ng-content>
<ng-content select="igx-paginator,igc-paginator"></ng-content>
</div>
Expand Down
4 changes: 2 additions & 2 deletions projects/igniteui-angular/grids/hierarchical-grid/src/hierarchical-grid.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
</div>
</div>

<div class="igx-grid__scroll" [style.height.px]="scrollSize" #scr [hidden]="isHorizontalScrollHidden" (pointerdown)="$event.preventDefault()">
<div class="igx-grid__scroll" role="presentation" [style.height.px]="scrollSize" #scr [hidden]="isHorizontalScrollHidden" (pointerdown)="$event.preventDefault()">
<div class="igx-grid__scroll-start" [style.width.px]="pinnedStartWidth" [style.min-width.px]="pinnedStartWidth"></div>
<div class="igx-grid__scroll-main" [style.width.px]="unpinnedWidth">
<ng-template igxGridFor [igxGridForOf]="[]" #scrollContainer>
Expand All @@ -175,7 +175,7 @@
<div class="igx-grid__scroll-end" [style.width.px]="pinnedEndWidth" [style.min-width.px]="pinnedEndWidth" [hidden]="pinnedEndWidth === 0"></div>
</div>

<div class="igx-grid__footer" #footer>
<div class="igx-grid__footer" role="presentation" #footer>
<ng-content select="igx-grid-footer,igc-grid-footer"></ng-content>
<ng-content select="igx-paginator,igc-paginator"></ng-content>
<ng-container #paginatorOutlet></ng-container>
Expand Down
4 changes: 2 additions & 2 deletions projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
<div #igxBodyOverlayOutlet="overlay-outlet" igxOverlayOutlet></div>
</div>

<div class="igx-grid__scroll" [style.height.px]="scrollSize" #scr [hidden]="isHorizontalScrollHidden" (pointerdown)="$event.preventDefault()">
<div class="igx-grid__scroll" role="presentation" [style.height.px]="scrollSize" #scr [hidden]="isHorizontalScrollHidden" (pointerdown)="$event.preventDefault()">
<div class="igx-grid__scroll-start" [style.width.px]="pivotPinnedStartWidth" [style.min-width.px]="pivotPinnedStartWidth"></div>
<div class="igx-grid__scroll-main" [style.width.px]="pivotUnpinnedWidth">
<ng-template igxGridFor [igxGridForOf]="EMPTY_DATA" #scrollContainer>
Expand All @@ -97,7 +97,7 @@
<div class="igx-grid__tfoot" role="rowgroup" #tfoot>
</div>

<div class="igx-grid__footer" #footer>
<div class="igx-grid__footer" role="presentation" #footer>
<ng-content select="igx-grid-footer,igc-grid-footer"></ng-content>
</div>

Expand Down
9 changes: 8 additions & 1 deletion projects/igniteui-angular/grids/tree-grid/src/tree-grid-group-by-area.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { AfterContentInit, Component, Input, IterableDiffer, IterableDiffers, OnDestroy, booleanAttribute, inject } from '@angular/core';
import { AfterContentInit, Component, HostBinding, Input, IterableDiffer, IterableDiffers, OnDestroy, booleanAttribute, inject } from '@angular/core';
import { Subject } from 'rxjs';
import { takeUntil } from 'rxjs/operators';
import { IChipsAreaReorderEventArgs, IgxChipComponent, IgxChipsAreaComponent } from 'igniteui-angular/chips';
Expand All @@ -23,6 +23,13 @@ import { IgxGroupAreaDropDirective, IgxGroupByAreaDirective, IgxGroupByMetaPipe
export class IgxTreeGridGroupByAreaComponent extends IgxGroupByAreaDirective implements AfterContentInit, OnDestroy {
private differs = inject(IterableDiffers);

/**
* @hidden
* @internal
*/
@HostBinding('attr.role')
public role = 'presentation';

@Input({ transform: booleanAttribute })
public get hideGroupedColumns() {
return this._hideGroupedColumns;
Expand Down
4 changes: 2 additions & 2 deletions projects/igniteui-angular/grids/tree-grid/src/tree-grid.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
</div>
</div>

<div class="igx-grid__scroll" [style.height.px]="scrollSize" #scr [hidden]="isHorizontalScrollHidden" (pointerdown)="$event.preventDefault()">
<div class="igx-grid__scroll" role="presentation" [style.height.px]="scrollSize" #scr [hidden]="isHorizontalScrollHidden" (pointerdown)="$event.preventDefault()">
<div class="igx-grid__scroll-start" [style.width.px]='pinnedStartWidth' [style.min-width.px]='pinnedStartWidth'></div>
<div class="igx-grid__scroll-main" [style.width.px]='unpinnedWidth'>
<ng-template igxGridFor [igxGridForOf]='[]' #scrollContainer>
Expand All @@ -166,7 +166,7 @@
<div class="igx-grid__scroll-end" [style.width.px]='pinnedEndWidth' [style.min-width.px]='pinnedEndWidth' [hidden]="pinnedEndWidth === 0"></div>
</div>

<div class="igx-grid__footer" #footer>
<div class="igx-grid__footer" role="presentation" #footer>
<ng-content select="igx-grid-footer,igc-grid-footer"></ng-content>
<ng-content select="igx-paginator,igc-paginator"></ng-content>
</div>
Expand Down
Loading