This repository was archived by the owner on Nov 24, 2024. It is now read-only.
Fix visualization for pythonocc 7.4.0 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following up the issue disscused here: https://sourceforge.net/p/ifcopenshell/discussion/1782717/thread/06e3103d93/ The yield and for-loop in initialize_display() changed slightly, 'GetHandles' and 'SetDiffuse' were removed. The directions are now V3d_TypeOfOrientation enumerations (randomly chosen by me) instead of tuples of integers.
Collaborator
|
Hi. Thanks for this, but I don't have notifications setup for this repository. Can you please post your pull request at the main repo https://github.com/IfcOpenShell/IfcOpenShell. |
IfcOpenBot
pushed a commit
that referenced
this pull request
Sep 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up the issue disscused here: https://sourceforge.net/p/ifcopenshell/discussion/1782717/thread/06e3103d93/
The yield and for-loop in initialize_display() changed slightly. 'GetHandle' and 'SetDiffuse' were removed because of attribute errors. The directions are now V3d_TypeOfOrientation enumerations (randomly chosen by me) instead of tuples of integers. Not sure if these changes cause problems for other use cases.
According to '2. transparent handles' in the link below all the calls 'GetObject' and 'GetHandle' can be removed.
https://github.com/tpaviot/pythonocc-core/wiki/Porting-from-0.18.x-to-7.4.0