fix: Add missing cycles dbt model

[martyngigg]

Summary

After deploying the new terraform-based platform with OpenFGA installed (#211) it was observed that the "cycles" dataset was missing from the dbt models directory and a chart was broken. It's likely some old refactoring removed the model but the dataset persisted in Superset.

This has highlighted an issue with syncing of datasets - anything currently deleted in dbt does not get deleted from the warehouse/Superset. It's not immediately clear what the best course of action is:

• if the model was deleted in error then automatically deleting from the warehouse would make the data harder to retrieve again
• leaving models around in the warehouse that are not in source control causes lack of clarity around the expected state of the warehouse.

Refs #211

Summary by CodeRabbit

Release Notes

• Refactor

  • Consolidated project structure with updated namespace naming across configurations and data models.
  • Streamlined intermediate model definitions by integrating logic directly into primary operations models.
  • Reorganised schema hierarchy to simplify data warehouse structure.

• Chores

  • Updated configuration profile references to align with new project naming scheme.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The pull request renames the dbt project from accelerator to accelerator_ops, updates corresponding profile and configuration references, removes the intermediate model int_cycles_start_end, renames int_cycle_phases_without_target to cycles, and adjusts downstream dependencies to use the newly renamed model.

Changes

Cohort / File(s)	Summary
Configuration Updates warehouses/accelerator_ops/transform/dbt_project.yml, warehouses/accelerator_ops/transform/profiles.yml	Renamed project name from accelerator to accelerator_ops; updated profile key from trino_catalog to accelerator_ops_catalog; removed intermediate schema configuration block.
Model Deletion warehouses/accelerator_ops/transform/models/intermediate/int_cycles_start_end.sql, warehouses/accelerator_ops/transform/models/intermediate/int_cycles_start_end.yml	Removed intermediate model int_cycles_start_end including its SQL logic and YAML metadata with column tests (not_null, unique).
Model Restructuring warehouses/accelerator_ops/transform/models/operations/cycles.yml	Renamed model entry identifier from int_cycle_phases_without_target to cycles.
Dependency Refactoring warehouses/accelerator_ops/transform/models/operations/mcr_equipment_downtime_records.sql	Removed unused cycles_start_end CTE; updated join reference from int_cycle_phases_without_target to cycles for cycle data enrichment.

Poem

🐰 Hop along as schemas dance and sway,
Accelerator ops has found its way,
We've trimmed the intermediate, streamlined with flair,
Renamed cycles bright—simplicity's there! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title states 'Add missing cycles dbt model' but the changeset actually removes the int_cycles_start_end model and renames the cycles model, alongside catalog/project restructuring.	Revise title to more accurately reflect the primary changes: e.g., 'refactor: Restructure accelerator to accelerator_ops and consolidate cycle models' or 'refactor: Remove int_cycles_start_end and rename cycles model'.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into main

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

warehouses/accelerator_ops/transform/models/operations/mcr_equipment_downtime_records.sql (1)

129-129: ⚠️ Potential issue | 🟡 Minor

Minor typo in comment: "crterion" → "criterion".

Pre-existing, but worth fixing while you're here.

Proposed fix

--- add order by clause for iceberg table sorting crterion
+-- add order by clause for iceberg table sorting criterion