chore: Revert back to single warehouse in local dev setup

[martyngigg]

Summary

See comment in #203 for more details on why the data layout is being reverted.

Fixes #203

Summary by CodeRabbit

Release Notes

• Chores
  • Consolidated warehouse configuration structure in the local development environment by unifying multiple warehouse definitions into a single "playground" warehouse configuration.
  • Updated configuration to use parameterised environment variables instead of hard-coded warehouse names, enabling more flexible deployment configurations.
  • Removed deprecated warehouse configuration files to simplify infrastructure setup.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The pull request consolidates the local development environment from separate warehouses (dev_isis_raw and dev_isis_cleaned) into a single "playground" warehouse. Configuration files transition to using a dynamic WAREHOUSE_NAME environment variable, bootstrap logic simplifies from iterating multiple warehouses to invoking a single one, and unused warehouse-specific configurations are removed.

Changes

Cohort / File(s)	Summary
Documentation infra/local/README.md	Updated warehouse and database references from separate names to unified "playground" warehouse in configuration examples.
Environment Configuration infra/local/env-local, infra/local/docker-compose.yml, infra/local/superset/docker/docker-init.sh	Introduced WAREHOUSE_NAME environment variable set to "playground". Refactored bootstrap flow from multi-warehouse iteration to single-warehouse invocation. Updated database connection setup and Superset root path to use dynamic variable reference instead of hardcoded values.
Lakekeeper Warehouse Configuration infra/local/warehouses/lakekeeper/bootstrap-dev_isis_raw.json (deleted), infra/local/warehouses/lakekeeper/playground.json	Removed legacy dev_isis_raw bootstrap configuration. Updated playground warehouse configuration name from "dev_isis_cleaned" to "playground".
Trino Warehouse Configuration infra/local/warehouses/trino/dev_isis_raw.properties (deleted), infra/local/warehouses/trino/playground.properties	Removed legacy Iceberg REST catalogue and S3 storage configuration for dev_isis_raw. Parameterised warehouse reference in playground configuration to use WAREHOUSE_NAME environment variable.

Poem

🐰 One playground to rule them all,

No more warehouses, big and small,

Consolidated with a variable's call,

Simpler configs—we cleaned up the hall! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR's changes directly contradict the linked issue #203 objectives by reverting from stage-oriented warehouses back to a single warehouse, moving away from the medallion-style architecture proposed in issue #203.	Clarify whether this PR is intentionally reverting the changes from issue #203, or if it implements issue #203 requirements differently. If reverting, provide rationale; if implementing, align changes with the stage-oriented warehouse architecture objectives.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The pull request title clearly and specifically describes the main change: reverting to a single warehouse configuration in the local development setup.
Out of Scope Changes check	✅ Passed	All changes are directly related to the local development warehouse configuration and are in scope with the PR's stated objective of reverting to a single warehouse setup.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

infra/local/warehouses/lakekeeper/playground.json (1)

2-11: ⚠️ Potential issue | 🟡 Minor

Storage bucket still references dev-isis-cleaned whilst the warehouse is now playground.

The warehouse-name on line 2 has been updated to "playground", but the S3 bucket on line 11 still reads "dev-isis-cleaned". This won't break anything functionally — the bucket is just a physical storage location — but the naming mismatch could confuse contributors. Consider renaming the bucket to something consistent (e.g. "playground") if existing local MinIO data can be discarded/recreated easily.

🤖 Fix all issues with AI agents

In `@infra/local/env-local`:
- Line 119: The README still references /workspace/localdev while
infra/local/env-local sets SUPERSET_APP_ROOT to /workspace/playground; update
the README.md occurrence(s) of the URL and any path examples to use
/workspace/playground (e.g., change http://localhost:50080/workspace/localdev to
http://localhost:50080/workspace/playground) and, if helpful, mention that the
path is derived from the SUPERSET_APP_ROOT/WAREHOUSE_NAME setting so it stays
correct when env-local changes.

In `@infra/local/warehouses/trino/playground.properties`:
- Line 3: Replace the incorrect environment substitution for the property
iceberg.rest-catalog.warehouse: change the literal ${WAREHOUSE_NAME} to Trino's
environment expansion syntax ${ENV:WAREHOUSE_NAME} so the Iceberg REST catalog
picks up the runtime value; update the value for iceberg.rest-catalog.warehouse
accordingly.

🧹 Nitpick comments (1)

infra/local/env-local (1)

77-77: Minor nit: WAREHOUSE_NAME is placed outside any section block.

Consider moving it under a dedicated header or into the "Iceberg catalog" section above for better discoverability.