fix: fix bug in notifications API related to SUBMITTEDDS notifications

[vera]

What this PR does / why we need it:

While using the notifications API with inAppNotificationFormat=true, I saw a lot of notifications about supposedly deleted datasets being submitted for review:

However, I knew these datasets weren't actually deleted. After looking at the relevant Dataverse code, I believe I found a bug in InAppNotificationsJsonPrinter.

It tries to use the notification's objectId to look up the relevant dataset by ID, however, the notification's objectId is not a dataset ID. It's a dataset version ID:

dataverse/src/main/java/edu/harvard/iq/dataverse/engine/command/impl/SubmitDatasetForReviewCommand.java

Line 66 in 8c23bf2

ctxt.notifications().sendNotification(au, new Timestamp(new Date().getTime()), UserNotification.Type.SUBMITTEDDS, savedDataset.getLatestVersion().getId(), "", requestor, false);

I've changed the code to correctly use the objectId to look up a dataset version by ID.

Special notes for your reviewer:

/

Suggestions on how to test this:

I believe this bug might not always show up, for example in simple test cases which only create a single dataset with a single version, because in that case, it's possible that the dataset version ID and dataset ID are in sync. I've therefore slightly extended the InReviewWorkflowIT test case to create a second dataset version to try and force the bug to show up.

In my tests, it's worked. Without the fix, the test failed:

[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   InReviewWorkflowIT.testCuratorSendsCommentsToAuthor:459 1 expectation failed.
JSON path data[0].datasetPersistentIdentifier doesn't match.    

With the fix, the test succeeded.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

/

Is there a release notes update needed for this change?:

I'm not sure this is a highly relevant bug, so maybe not.

Additional documentation:

/

[stevenwinship]

@vera
Could you take a look at the failing test (InAppNotificationsJsonPrinterTest.testAddFieldsByType_submittedDs)?
I merged develop into this branch because of a small conflict (nothing to do with this failure)
The failing test works if I undo your change to the "addDatasetVersionFields(notificationJson, userNotification);" line.

[vera]

@vera Could you take a look at the failing test (InAppNotificationsJsonPrinterTest.testAddFieldsByType_submittedDs)? I merged develop into this branch because of a small conflict (nothing to do with this failure) The failing test works if I undo your change to the "addDatasetVersionFields(notificationJson, userNotification);" line.

Should be fixed now!