Report energy deltas in keV instead of eV #2543
Merged
+17
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #2542 by converting Lo L2 energy delta values from eV to keV to match the units used for energy values, enabling proper computation of L3 spectral index maps.
- Multiplies energy delta values by 1e-3 to convert from eV to keV
- Adds test assertion to verify energy deltas are in keV (values < 1)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| imap_processing/lo/l2/lo_l2.py | Applies 1e-3 conversion factor to energy_delta_minus and energy_delta_plus for both HiRes and HiThr ESA modes |
| imap_processing/tests/lo/test_lo_l2.py | Adds assertion to verify energy_delta_plus values are less than 1 keV |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
greglucas
approved these changes
Dec 29, 2025
subagonsouth
merged commit 19f1d25
into
IMAP-Science-Operations-Center:dev
14 checks passed
subagonsouth
deleted the
2542-lo-l2---energy-is-in-kev-while-energy-deltas-are-in-ev
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Report Lo energy_deltas in keV instead of eV.
Closes: #2542