Catch when bad time zone is found and proceed with out any zone infor… #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarhurst
approved these changes
Sep 16, 2025
Contributor
|
@danhamill Thank you for the bug fix. It looks good to me, feel free to merge when you are ready. |
Contributor
Author
|
Looks like maybe I forgot to bump the version in the CI job. |
Contributor
Author
|
I didnt intend to make a release with this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a case where the time zone id in DSS cannot be recognized by ZoneInfo. "GMT +00:00" is not a valid key.
Suggested trapping this error and proceeding to return with out any time zone info.