Closed
Conversation
|
Fixed conflicts |
|
Check passed 💃 |
|
@roschaefer this seems ready :3 |
roschaefer
force-pushed
the
register_module
branch
from
df84257 to
992c08b
Compare
Contributor
Author
|
I think we could merge that, too |
appinteractive
previously requested changes
Oct 5, 2018
Member
There was a problem hiding this comment.
session on the server side (SSR) is not destroyed which leads to the following scenario:
- login as admin (test@test.de)
- logout
- login as regular user (test3@test3.de)
- refresh page after you are logged in
- see that you are logged in again as the last user (admin) instead of your last loggin (user)
You need to remove that session also on the server side, maybe there is a cookie still flying around in the browser which is then send on SSR and the backend responds with the logged in user from the token in the cookie.
``` session on the server side (SSR) is not destroyed which leads to the following scenario: 1. login as admin (test@test.de) 2. logout 3. login as regular user (test3@test3.de) 4. refresh page after you are logged in 5. see that you are logged in again as the last user (admin) instead of your last loggin (user) You need to remove that session also on the server side, maybe there is a cookie still flying around in the browser which is then send on SSR and the backend responds with the logged in user from the token in the cookie. ``` This is not possible now, as the lazy-loading happens with `app.$api` and not the socket.
Contributor
Author
|
Covered in #218 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and configure it at runtime, yay!