added rakefile check for ENV['ARRAY_CYCLES_DISABLE'] (this can now live ...#132
Open
SimianLogic wants to merge 1 commit intoHipByte:masterfrom
Open
added rakefile check for ENV['ARRAY_CYCLES_DISABLE'] (this can now live ...#132SimianLogic wants to merge 1 commit intoHipByte:masterfrom
SimianLogic wants to merge 1 commit intoHipByte:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...in source)
Hey guys,
I have two live games using RM now -- one using the cycle detector with no problems and one that hangs without ARR_CYCLES_DISABLE=1 specified at rake time. As I'm doing updates for the two projects, it's starting to be a headache to remember which one I use it on and which one I disable it on. I poked through the source and it seems pretty trivial to just add it as a config variable in the Rakefile for the project.
Now it can live in source and give me piece of mind!
I only implemented my actual use case, but it would be trivial to change it so that it actually replaces the setenv call with the value specified by the @environment_variables hash... let me know!