This repository was archived by the owner on Apr 26, 2024. It is now read-only.
refactor BundleValidator.validate#259
Open
dzhelezov wants to merge 77 commits intoHelixNetwork:devfrom
Open
Conversation
take changes from dev
give the user a chance to change the spent addresses db path
add push method evicting the last queue element
Transaction should be confirmed only after balance is updated.
Remove unused import
…sorting Sort merkle leaves and sort consistent tips
log all tangle published messages into a separate file for processing
add `sldf` ZMQ topic
Update README.MD
Configuration refactor
remove time check for milestones
Contributor
Author
|
Added a fix causing inconsistent balances |
roundDuration should be read off from config, not defaults
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a substantial refactoring of BundleValidator.validate() routine. As we don't have sufficient test coverage, it may be breaking.