Bindless : First draft #1323
Draft
Bindless : First draft #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncannasse
reviewed
Dec 20, 2025
h3d/scene/MeshBatch.hx
Outdated
| public var indirectCallBuffers : Array<h3d.impl.InstanceBuffer>; | ||
| public var buffers : Array<h3d.Buffer> = []; | ||
| public var bufferFormat : hxd.BufferFormat; | ||
| public var textureHandles : Array<h3d.mat.TextureHandle> = []; |
Member
There was a problem hiding this comment.
I would set this as null and only create the array (and call the selectTextureHandles) if the feature is used. Otherwise this will alloc a lot of empty arrays and error on selectuTextureHandle on some platforms.
h3d/shader/Buffers.hx
Outdated
| public var globals : ShaderBufferData; | ||
| public var globalsHandles : haxe.ds.Vector<h3d.mat.TextureHandle>; | ||
| public var params : ShaderBufferData; | ||
| public var paramsHandles : haxe.ds.Vector<h3d.mat.TextureHandle>; |
Member
There was a problem hiding this comment.
I don't see much need to have separate global and params handles. I think these should be merged into a single handles Vector. We can still have two counts so we offset (params after globals) when writing.
h3d/impl/DX12Driver.hx
Outdated
| public var uploadBuffer : TextureUploadBuffer; | ||
| var clearColorChanges : Int; | ||
| public var cpuViewsIndex : Array<Int> = [for (i in 0...16) -1]; | ||
| public var handles : Map<Int, h3d.mat.TextureHandle> = []; |
Member
There was a problem hiding this comment.
Only create map on request (in getTextureHandles)
…array in MeshBatch and DX12Driver to avoid unnecessary array allocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first draft of a bindless implementation for heaps in DX12 only.
It introduces a new HXSL type TextureHandle which can used to retrieve textures without binding them. This enables us to remove the 16 textures limit and their binding cost.
Per-instance TextureHandle is supported. I have added a bindless sample demonstrating both simple and per instance bindless.
In order to easily introduce these new features, we should add a way for the HXSL compiler to convert texture bindings to a bindless scheme.
As discussed with Nicolas, this could look like the following :
@bindless @param var texture : Sampler2Dor
@perInstance @param var texture : Sampler2DThis still needs to be implemented, but it isn't required for these changes.