Skip to content

Conversation

@FlorianSW
Copy link
Member

Fixes #78

"queryset_class": CustomQuerySet
}

def clean(self):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach is only clever, if we are sure there is no invalid data in the db already, which the system needs to be able to save again. Reading shouldn't be an issue, though.

@hoersamu
Copy link
Member

I think we should remove the check whether one side has more than 50 players since theoretically 51vs49 is a valid linup.

@FlorianSW
Copy link
Member Author

It is? 🤔

@hoersamu
Copy link
Member

@Soxxes 51vs49 is a valid game right?

@HeLO-System HeLO-System deleted a comment from sonarqubecloud bot Oct 20, 2022
@FlorianSW
Copy link
Member Author

The frontend, when used to report a match, currently checks for max 50 players per side as well 😅
https://github.com/HeLO-System/HeLO-App/blob/main/src/pages/api/reportMatch.ts#L118-L125

@hoersamu
Copy link
Member

Fair point but that doesn't make it right.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

too many players, should be catched in calculations

2 participants