Preview PRs using Harper Fabric ✨ #408
Conversation
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-docs.stage.harperfabric.com:9925//pr-408 This preview will update automatically when you push new commits. |
|
👀 |
|
🤫 |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-docs.stage.harperfabric.com/pr-408 This preview will update automatically when you push new commits. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-docs.stage.harperfabric.com/pr-408 This preview will update automatically when you push new commits. |
|
I'm going to attempt the close and reopen flows now. |
🧹 Preview CleanupThe preview deployment for this PR has been removed. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-docs.stage.harperfabric.com/pr-408 This preview will update automatically when you push new commits. |
🧹 Preview CleanupThe preview deployment for this PR has been removed. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-docs.stage.harperfabric.com/pr-408 This preview will update automatically when you push new commits. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-docs.stage.harperfabric.com/pr-408 This preview will update automatically when you push new commits. |
.github/workflows/deploy.yaml
Outdated
| group: pages-${{ github.event_name }}-${{ github.event_name == 'pull_request' && github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: ${{ github.event_name == 'pull_request' }} | ||
| group: production-deploy | ||
| cancel-in-progress: false |
There was a problem hiding this comment.
might as well cancel in progress just in case the newer one is faster to build and deploy than an earlier one. could get in a weird state.
heskew
left a comment
heskew
left a comment
There was a problem hiding this comment.
sweet. love the prod workflow cleanup too.
is there a risk of someone cutting a pr we don't notice and putting something malicious up on an official lookin (though clearly not 'production') harper site? can we put it on a manual gate to start, eventually auto deploy trusted groups/individuals?
|
I believe GitHub requires us to approve workflow runs for non-collaborators. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-docs.stage.harperfabric.com/pr-408 This preview will update automatically when you push new commits. |
.github/workflows/deploy.yaml
Outdated
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
Generally, I don't think you want fetch-depth: 0 as it will download the entire git history when you probably only need the most recent commit which is faster.
There was a problem hiding this comment.
Not sure why this is here but can remove
.github/workflows/pr-preview.yaml
Outdated
| - name: Install HarperDB CLI | ||
| run: | | ||
| npm install harperdb |
There was a problem hiding this comment.
Why not install harper globally? Then I would think you wouldn't need npx on the next step, right?
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-docs.stage.harperfabric.com/pr-408 This preview will update automatically when you push new commits. |
🧹 Preview CleanupThe preview deployment for this PR has been removed. |
* initializing the new learn tab * progress * install page draft complete * clean up versioned content and sidebars * ohhh prettier * iterate on installation docs more and stub out rest of getting started * keep getting started simple * quick edits before format * fix redirects and format * wtf prettier * fix broken links * fix some config * fixes * add deploy to fabric section * switch to PUT * add repo branch references to subsections * Preview PRs using Harper Fabric ✨ (#408) * first pass * fix workflow maybe * try again * beep boop * - to _ * fix preview-pr script * cancel-in-progress for deploy * fix fetch depth and global install harper * Apply suggestions from code review Co-authored-by: Chris Barber <chris@harperdb.io> * Update release-notes/v4-tucker/4.2.0.md Co-authored-by: Chris Barber <chris@harperdb.io> --------- Co-authored-by: Chris Barber <chris@harperdb.io>
This PR adds a new workflow for deploying PRs to a Harper Fabric cluster for previewing. You can see how it works in this PR itself.