Skip to content

Implement Employment History#304

Open
MBreathe wants to merge 12 commits intoHackYourFuture:mainfrom
MBreathe:feature/employment-history-ui
Open

Implement Employment History#304
MBreathe wants to merge 12 commits intoHackYourFuture:mainfrom
MBreathe:feature/employment-history-ui

Conversation

@MBreathe
Copy link
Contributor

@MBreathe MBreathe commented Feb 11, 2026

This pull request adds a new Employment History UI with adding/editing/deleting, additionally focuses on updating MUI (Material UI) component usage and improving code consistency in the trainee profile's education strikes feature. It also cleans up the package-lock.json by removing unnecessary peer fields from dependencies. The most important changes are summarized below:

MUI v5 Migration and Component Updates

  • Updated StrikeDetailsModal.tsx to use the new MUI v5 slots and slotProps API for Modal and TextField components, replacing deprecated BackdropComponent, BackdropProps, and InputLabelProps usage.
  • Changed style props such as bgcolor to backgroundColor for better clarity and consistency with the MUI v5 API.

Code Consistency and Cleanup

  • Refactored style props in StrikesList.tsx to use MUI shorthand (e.g., pr, px, py) and fixed typos like alignIntems to alignItems.
  • Added a missing import React from 'react' in StrikesList.tsx for clarity and consistency.

Dependency File Maintenance

  • Removed all "peer": true fields from dependency entries in client/package-lock.json, which are not required and help keep the lock file clean.

@MBreathe MBreathe self-assigned this Feb 11, 2026
Copilot AI review requested due to automatic review settings February 11, 2026 16:34
@MBreathe MBreathe added the FE Frontend ticket label Feb 11, 2026
@MBreathe MBreathe linked an issue Feb 11, 2026 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new Employment History CRUD UI for trainee profiles, updates parts of the education “strikes” UI to MUI’s newer slots / slotProps APIs, and cleans up client/package-lock.json.

Changes:

  • Added React Query hooks and UI components (list + modal) to add/edit/delete trainee employment history entries.
  • Updated strikes components to use MUI slots/slotProps and cleaned up styling props/typos.
  • Removed "peer": true fields from dependencies in client/package-lock.json.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
client/src/features/trainee-profile/employment/data/employment-queries.ts New React Query hooks for employment history endpoints.
client/src/features/trainee-profile/employment/EmploymentsList.tsx New list UI for rendering employment history entries with actions.
client/src/features/trainee-profile/employment/EmploymentDetailsModal.tsx New modal form for adding/editing employment entries.
client/src/features/trainee-profile/employment/EmploymentInfo.tsx Integrates employment history querying + modal + delete confirmation into the Employment tab.
client/src/features/trainee-profile/education/strikes/StrikesList.tsx Style prop cleanup, shorthand usage, and typo fix (alignItems).
client/src/features/trainee-profile/education/strikes/StrikeDetailsModal.tsx Migrates Modal/TextField props to MUI slots/slotProps and clarifies styles.
client/package-lock.json Removes unnecessary "peer": true fields from lockfile entries.
Files not reviewed (1)
  • client/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MBreathe MBreathe changed the title Emplement Employment History Implement Employment History Feb 11, 2026
…to api/api.ts, adjusted styling to fit criteria, fixed typo isEditing=>!isEditing, applied copilot feedback in most places
Copy link
Contributor

@zalexa19 zalexa19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!
I left some comments, but nothing major or critical :)

I can see that it was inspired by the strikes section, and unfortunatellly the strikes sections needs a bit of polish :sweat-smile:
I plan on cleaning it up a bit, and probably tests and interactions as well (as it was also inspired by the stikes)
My appoligies if this mislead you.
But regardless,
it looks very good! the code was very easy to follow and I appreciate it that you also fixed the slotProps :)

@HackYourFutures HackYourFutures temporarily deployed to dojo-feature-employment-rybk9p February 14, 2026 19:29 Inactive
@HackYourFutures HackYourFutures temporarily deployed to dojo-feature-employment-rybk9p February 16, 2026 11:23 Inactive
@MBreathe MBreathe requested a review from zalexa19 February 16, 2026 11:25
@HackYourFutures HackYourFutures temporarily deployed to dojo-feature-employment-rybk9p February 16, 2026 11:26 Inactive
@HackYourFutures HackYourFutures temporarily deployed to dojo-feature-employment-rybk9p February 17, 2026 08:24 Inactive
Copy link
Contributor

@zalexa19 zalexa19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Thank you so much for cleaning up the try/catch in the api and adding a key factory :)

@HackYourFutures HackYourFutures temporarily deployed to dojo-feature-employment-rybk9p February 18, 2026 10:04 Inactive
@MBreathe MBreathe closed this Feb 18, 2026
@MBreathe MBreathe reopened this Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FE Frontend ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Employment history UI

3 participants