Skip to content

Conversation

@Glavo
Copy link
Member

@Glavo Glavo commented Jan 10, 2026

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request converts the FontReference class to a Java record, modernizing the code while maintaining the same functionality.

Changes:

  • Converted FontReference from a traditional class to a Java record
  • Replaced manual getter methods getFamily() and getStyle() with record accessor methods family() and style()
  • Updated all call sites to use the new accessor method names

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
HMCL/src/main/java/org/jackhuang/hmcl/setting/FontManager.java Converted FontReference class to record with compact constructor for null validation and updated getter method call in static initializer
HMCL/src/main/java/org/jackhuang/hmcl/setting/StyleSheets.java Updated method calls from getFamily()/getStyle() to family()/style() to use record accessors

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Glavo Glavo merged commit ab5ef6e into HMCL-dev:main Jan 10, 2026
8 checks passed
@Glavo Glavo deleted the FontReference branch January 10, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant