Skip to content

Conversation

@Glavo
Copy link
Member

@Glavo Glavo commented Dec 26, 2025

No description provided.

@anjisuan608
Copy link

当前状态似乎未有效解决问题

测试使用的认证服务器为在登录账户窗口中添加的 MUA: https://skin.mualliance.ltd/api/yggdrasil

  • image
  • image

添加后自定义认证服务器用户名检测和之前一致

  • image

本PR让LittleSkin会时时刷新检测邮箱

  • image

我大概在 #5069 中没有描述清楚问题

诉求是要littleskin的用户名像其它自定义外置登录一样不检测邮箱格式

和登录账户的界面效果保持一致

  • image
  • image

LittleSkin的登录界面允许使用用户名登录,而非必须使用邮箱登录

  • image

因此应当取消该邮箱检测限制和账户管理中添加littleskin账户的逻辑保持一致

  • image

@Glavo
Copy link
Member Author

Glavo commented Jan 1, 2026

我检查了一下,是 LittleSkin 的元数据里拼写错误导致的,他们把 feature.non_email_login 拼写成了 feature.no_email_login,所以正确行为应该就是不能输入用户名。

我检查一下为什么另一个位置会错误的允许用户通过用户名登录。

@Glavo
Copy link
Member Author

Glavo commented Jan 1, 2026

LittleSkin 回应了我们,他们那边会修复拼写错误的问题,修复完成后就能解决这些输入框不接受用户名的问题。

@Glavo Glavo changed the title Fix #5069: 修复 AccountDetailsInputPane 在切换认证服务器时不会重新验证用户名的问题 修复 AccountDetailsInputPane 部分情况下未正确验证用户名的问题 Jan 1, 2026
@Glavo Glavo requested a review from Copilot January 1, 2026 13:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where AccountDetailsInputPane failed to properly validate usernames in certain scenarios involving authlib-injector account creation. The issue occurred because the username validation logic didn't account for all cases when determining if an email format was required.

Key Changes:

  • Added validation trigger when the server selection changes in the combo box, ensuring username requirements are re-evaluated
  • Extended requiresEmailAsUsername() to handle BoundAuthlibInjectorAccountFactory, which was previously missing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Glavo Glavo merged commit 0c657ef into HMCL-dev:main Jan 1, 2026
8 checks passed
@Glavo Glavo deleted the fix-5069 branch January 1, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants