Line Tool: Only lock angle with Ctrl after drag has started#3773
Open
JustJ01 wants to merge 2 commits intoGraphiteEditor:masterfrom
Open
Line Tool: Only lock angle with Ctrl after drag has started#3773JustJ01 wants to merge 2 commits intoGraphiteEditor:masterfrom
JustJ01 wants to merge 2 commits intoGraphiteEditor:masterfrom
Conversation
Contributor
Author
|
@Keavon @timon-schelling @adamgerhant pls review! |
Member
|
Thanks for the contribution. Tagging us will not get the PR reviewed quicker and just adds noise. We see open PRs and will review them when we find the time. |
JustJ01
force-pushed
the
fix-line-tool
branch
from
e106042 to
7654bdc
Compare
Contributor
Author
|
Sorry for unnecessary tagging , won't do it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3771
Implemented the fix so Ctrl only angle locks the Line tool after drag has already started.
Applies to both drawing a new line and dragging an existing line endpoint.
Added per-drag eligibility tracking for lock-angle and reset it at drag lifecycle boundaries.
Also updated tests:
test_line_tool_ctrl_before_drag_start_does_not_lock_angletest_line_tool_ctrl_pressed_during_drag_locks_angle