Skip to content

chore: bump otelcontribcol to v0.127.0-gke.6#2049

Open
cowsking wants to merge 1 commit intoGoogleContainerTools:mainfrom
cowsking:main
Open

chore: bump otelcontribcol to v0.127.0-gke.6#2049
cowsking wants to merge 1 commit intoGoogleContainerTools:mainfrom
cowsking:main

Conversation

@cowsking
Copy link
Contributor

@cowsking cowsking commented Feb 6, 2026

No description provided.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cowsking. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link

Summary of Changes

Hello @cowsking, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine maintenance update by bumping the version of the OpenTelemetry Contrib Collector. This ensures that the project utilizes the latest specified version of this dependency, contributing to ongoing stability and access to recent features or fixes.

Highlights

  • Dependency Update: Updated the OpenTelemetry Contrib Collector (otelcontribcol) version in the Makefile from v0.127.0-gke.5 to v0.127.0-gke.6.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Makefile
    • Updated the OTELCONTRIBCOL_VERSION variable to v0.127.0-gke.6.
Activity
  • No specific review activity or comments have been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR bumps the otelcontribcol version. The change itself is correct, but it requires a related change in manifests/templates/otel-collector.yaml to remove an obsolete feature flag, as detailed in my comment. Without this additional change, the otel-collector is likely to fail.

GIT_SYNC_IMAGE_NAME := gcr.io/config-management-release/git-sync:$(GIT_SYNC_VERSION)

OTELCONTRIBCOL_VERSION := v0.127.0-gke.5
OTELCONTRIBCOL_VERSION := v0.127.0-gke.6

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Bumping to this version of otelcontribcol makes the --feature-gates=-pkg.translator.prometheus.NormalizeName flag used in manifests/templates/otel-collector.yaml obsolete. This feature gate was removed in v0.93.0 of opentelemetry-collector-contrib, and using it with v0.127.0 will likely cause the collector to fail. Please remove the flag and the associated comment from manifests/templates/otel-collector.yaml as part of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant