chore: bump otelcontribcol to v0.127.0-gke.6#2049
chore: bump otelcontribcol to v0.127.0-gke.6#2049cowsking wants to merge 1 commit intoGoogleContainerTools:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @cowsking, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine maintenance update by bumping the version of the OpenTelemetry Contrib Collector. This ensures that the project utilizes the latest specified version of this dependency, contributing to ongoing stability and access to recent features or fixes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR bumps the otelcontribcol version. The change itself is correct, but it requires a related change in manifests/templates/otel-collector.yaml to remove an obsolete feature flag, as detailed in my comment. Without this additional change, the otel-collector is likely to fail.
| GIT_SYNC_IMAGE_NAME := gcr.io/config-management-release/git-sync:$(GIT_SYNC_VERSION) | ||
|
|
||
| OTELCONTRIBCOL_VERSION := v0.127.0-gke.5 | ||
| OTELCONTRIBCOL_VERSION := v0.127.0-gke.6 |
There was a problem hiding this comment.
Bumping to this version of otelcontribcol makes the --feature-gates=-pkg.translator.prometheus.NormalizeName flag used in manifests/templates/otel-collector.yaml obsolete. This feature gate was removed in v0.93.0 of opentelemetry-collector-contrib, and using it with v0.127.0 will likely cause the collector to fail. Please remove the flag and the associated comment from manifests/templates/otel-collector.yaml as part of this change.
No description provided.