chore: bump otelcontribcol to v0.127.0-gke.5#2046
chore: bump otelcontribcol to v0.127.0-gke.5#2046google-oss-prow[bot] merged 1 commit intoGoogleContainerTools:mainfrom
Conversation
Summary of ChangesHello @cowsking, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine update to the version of the OpenTelemetry Contrib Collector dependency. The change ensures that the project utilizes the most current specified version, which can bring benefits such as improved stability, performance, or new features from the updated collector. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Camila-B The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This PR bumps the otelcontribcol version. I've added a comment regarding a potential issue with an obsolete feature gate being used for this dependency in another file. While the version bump itself is fine, this related issue should be addressed to prevent potential runtime failures.
| GIT_SYNC_IMAGE_NAME := gcr.io/config-management-release/git-sync:$(GIT_SYNC_VERSION) | ||
|
|
||
| OTELCONTRIBCOL_VERSION := v0.127.0-gke.4 | ||
| OTELCONTRIBCOL_VERSION := v0.127.0-gke.5 |
There was a problem hiding this comment.
While this version bump is a minor patch update, it's worth noting that we are using an obsolete feature gate for this dependency. The otelcontribcol version v0.127.0 no longer supports the pkg.translator.prometheus.NormalizeName feature gate, as it was removed in v0.90.0 (see opentelemetry-collector-contrib#27909).
We are still passing this feature gate in manifests/templates/otel-collector.yaml (line 117):
- "--feature-gates=-pkg.translator.prometheus.NormalizeName"This could cause the otel-collector to fail on startup if the flag is unrecognized.
I recommend creating a follow-up issue or pull request to remove this obsolete flag and the related comment.
8d1826e
into
GoogleContainerTools:main
* chore: bump go.opentelemetry.io/otel from 1.39.0 to 1.40.0 (#2036) Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 1.39.0 to 1.40.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.39.0...v1.40.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel dependency-version: 1.40.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump to Go 1.25.6 (#2042) * test: Fix test-git-server node affinity errors on Autopilot (#2033) Set empty nodeSelector and add resource requirements for Autopilot clusters to resolve optimize-utilization-scheduler scheduling failures. Example failure https://storage.googleapis.com/oss-prow-build-kpt-config-sync/logs/kpt-config-sync-autopilot-stable/2016983552020713472/build-log.txthttps://storage.googleapis.com/oss-prow-build-kpt-config-sync/logs/kpt-config-sync-autopilot-stable/2016983552020713472/build-log.txt * chore: bump go.opentelemetry.io/otel/sdk from 1.39.0 to 1.40.0 (#2037) Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.39.0 to 1.40.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.39.0...v1.40.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/sdk dependency-version: 1.40.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update Helm version to v3.18.6-gke.3 (#2045) * chore: bump google.golang.org/api from 0.264.0 to 0.265.0 (#2044) Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.264.0 to 0.265.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.264.0...v0.265.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-version: 0.265.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump otelcontribcol to v0.127.0-gke.5 (#2046) * chore: bump go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc (#2038) Bumps [go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc](https://github.com/open-telemetry/opentelemetry-go) from 1.39.0 to 1.40.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.39.0...v1.40.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc dependency-version: 1.40.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump git-sync to v4.4.2-gke.14 (#2048) * chore: bump git-sync to v4.4.2-gke.14 * chore: bump to Go 1.25.7 * chore: bump otelcontribcol to v0.127.0-gke.6 (#2049) * chore: update kustomize to v5.4.2-gke.3 (#2050) * chore: update kustomize to v5.4.2-gke.4 (#2051) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tiffany Pei <tiffanny29631@users.noreply.github.com>
No description provided.