-
Notifications
You must be signed in to change notification settings - Fork 1k
Feat(storage): add sample for list buckets partial success #2180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(storage): add sample for list buckets partial success #2180
Conversation
- Add `list_buckets_partial_success` snippet - Handle `unreachable()` metadata in the sample - Add system test to verify snippet execution
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @thiyaguk09, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new feature that enhances the resilience of applications interacting with Google Cloud Storage. It provides a mechanism to handle scenarios where some regions might be experiencing downtime while listing buckets, ensuring that the application can still retrieve available bucket information and identify unreachable resources, rather than failing entirely. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new code sample and a corresponding system test to demonstrate the 'returnPartialSuccess' feature when listing Cloud Storage buckets. The implementation is clear and effectively shows how to handle both reachable buckets and unreachable locations. My feedback is focused on improving the testing practices by removing a redundant assertion in the new system test.
This PR adds a new code sample and system test demonstrating how to handle Partial Success when listing Cloud Storage buckets.
The
returnPartialSuccessfeature is critical for building resilient applications. It allows thebuckets()method to return successfully even if specific regions are experiencing downtime, providing a list of reachable buckets along with a list of unreachable resource paths.Changes
storage_list_buckets_partial_successsnippet.unreachable()method inBucketIterator.Implementation Notes
assertTrue(true)at the end of the system test. This serves as a "completion assertion" to explicitly confirm that the entire snippet executed and returned without throwing an exception, which is particularly useful in system tests where the network is involved.unreachable()array will be empty. Therefore, we do not assert specific "Unreachable" output strings to avoid false negatives. The test instead focuses on verifying the reachableBucket:output, proving the API connection and thereturnPartialSuccessconfiguration are working correctly.