-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(PubSub): Add samples to create topics and subscriptions with SMT support #2179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @Hectorhammett, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Google Cloud Pub/Sub PHP client library documentation by adding practical code samples. These samples illustrate how to configure and create Pub/Sub topics and subscriptions with Single Message Transforms (SMT) enabled, using JavaScript User-Defined Functions (UDFs) to modify message payloads. This provides developers with clear guidance on implementing server-side message transformations, streamlining data processing workflows directly within Pub/Sub. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds new PHP samples for creating Pub/Sub topics and subscriptions with Single Message Transform (SMT) support. The overall implementation is good, but I've found a few issues that need to be addressed. There's a critical issue in the subscription creation sample where an incorrect method is used. Additionally, there are some minor issues in the test files, such as an undefined variable and misleading error messages, and a configuration issue in phpunit.xml.dist. I've provided detailed comments and suggestions for each of these points.
…o the correct folder
7c5bbd8 to
0526b83
Compare
0526b83 to
53a198a
Compare
Added the samples for PHP's PubSub library to create both Topics and Subscriptions with SMT.
b/427316648