-
Notifications
You must be signed in to change notification settings - Fork 2k
chore(genai): Update live-structured-ouput-with-txt.js to gimini-2.5-flash #4224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @angelcaamal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the generative AI model used in a JavaScript sample to a newer version, ensuring the sample leverages the latest capabilities and improvements of the Gemini Flash model for structured output generation. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully updates the model used in live-structured-ouput-with-txt.js from google/gemini-2.0-flash-001 to google/gemini-2.5-flash. The change is straightforward and aligns with the pull request's objective. A minor maintainability improvement could be considered for the model name.
|
|
||
| const completion = await openAI.chat.completions.create({ | ||
| model: 'google/gemini-2.0-flash-001', | ||
| model: 'google/gemini-2.5-flash', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The model name google/gemini-2.5-flash is currently a string literal. While this is a small change, it's generally good practice to define such configuration values as constants, especially if they might be reused or updated frequently. This improves maintainability and reduces the risk of typos if the value needs to be changed in the future.
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.