feat: Implement OneTime trigger for Dataplex Datascan #16024

sushilchaskar28 · 2025-12-23T22:50:19Z

dataplex: added `one_time` field to `google_dataplex_datascan` resource

github-actions · 2025-12-23T22:51:20Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-12-23T23:01:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 544 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 544 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 38 insertions(+))

modular-magician · 2025-12-23T23:17:21Z

Tests analytics

Total tests: 75
Passed tests: 57
Skipped tests: 0
Affected tests: 18

Click here to see the affected service packages

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-12-23T23:21:47Z

🟢 Tests passed during RECORDING mode:
TestAccDataplexDataQualityRules [Debug log]
TestAccDataplexDatascanDataplexDatascanFullQuality_update [Debug log]
TestAccDataplexDatascanIamBindingGenerated [Debug log]
TestAccDataplexDatascanIamMemberGenerated [Debug log]
TestAccDataplexDatascanIamPolicyGenerated [Debug log]
TestAccDataplexDatascan_dataplexDatascanBasicDiscoveryExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanBasicProfileExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanBasicQualityExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanDocumentationExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanFullDiscoveryExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanFullProfileTestExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanFullProfile_update [Debug log]
TestAccDataplexDatascan_dataplexDatascanFullQualityTestExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanOnetimeDiscoveryExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanOnetimeDocumentationExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanOnetimeProfileExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanOnetimeQualityExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDataplexEntry_dataplexEntryBigqueryTableExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Co-authored-by: Marek Lipert <lipertmj@google.com>

sushilchaskar28 · 2025-12-24T00:48:31Z

TestAccDataplexEntry_dataplexEntryBigqueryTableExample test failure is unrelated to the cl. Added a comment in 1e50597#r173423825

This is causing TestAccDataplexEntry_dataplexEntryBigqueryTableExample test failure in GoogleCloudPlatform#16024

sushilchaskar28 · 2025-12-24T01:06:57Z

raised separate #16026 to fix the entry test

modular-magician · 2025-12-24T01:12:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 544 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 544 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 38 insertions(+))

modular-magician · 2025-12-24T01:30:05Z

Tests analytics

Total tests: 75
Passed tests: 74
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-12-24T01:30:21Z

🔴 Tests failed during RECORDING mode:
TestAccDataplexEntry_dataplexEntryBigqueryTableExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2025-12-26T09:43:58Z

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

mmv1/products/dataplex/Datascan.yaml

modular-magician · 2025-12-31T23:19:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 544 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 544 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 38 insertions(+))

modular-magician · 2025-12-31T23:36:53Z

Tests analytics

Total tests: 75
Passed tests: 75
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

github-actions · 2026-01-05T09:49:31Z

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician · 2026-01-05T19:51:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 544 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 544 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 38 insertions(+))

modular-magician · 2026-01-05T20:10:29Z

Tests analytics

Total tests: 75
Passed tests: 75
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2026-01-05T23:19:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 427 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 5 files changed, 427 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 38 insertions(+))

modular-magician · 2026-01-05T23:38:36Z

Tests analytics

Total tests: 73
Passed tests: 72
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-05T23:39:11Z

🔴 Tests failed during RECORDING mode:
TestAccDataplexDatascanDataplexDatascanFullQuality_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-01-06T00:21:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 431 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 5 files changed, 431 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 38 insertions(+))

modular-magician · 2026-01-06T00:26:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 427 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 5 files changed, 427 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 38 insertions(+))

modular-magician · 2026-01-06T00:39:35Z

Tests analytics

Total tests: 73
Passed tests: 72
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-06T00:40:55Z

🟢 Tests passed during RECORDING mode:
TestAccDataplexDatascanDataplexDatascanFullQuality_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-01-06T00:43:30Z

Tests analytics

Total tests: 73
Passed tests: 72
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-06T00:44:54Z

🟢 Tests passed during RECORDING mode:
TestAccDataplexDatascanDataplexDatascanFullQuality_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-01-06T01:20:01Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 427 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 5 files changed, 427 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 38 insertions(+))

modular-magician · 2026-01-06T01:38:28Z

Tests analytics

Total tests: 73
Passed tests: 73
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

mmv1/third_party/terraform/services/dataplex/resource_dataplex_datascan_test.go

c2thorn

if one_time is immutable, we can mark it as such

mmv1/products/dataplex/Datascan.yaml

modular-magician · 2026-01-06T19:50:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 428 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 5 files changed, 428 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 38 insertions(+))

modular-magician · 2026-01-06T20:07:43Z

Tests analytics

Total tests: 73
Passed tests: 73
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

github-actions bot requested a review from c2thorn December 23, 2025 22:51

modular-magician added the service/dataplex label Dec 23, 2025

sushilchaskar28 referenced this pull request Dec 24, 2025

Improve Dataplex Entry support for first party entries. (#15861)

1e50597

Co-authored-by: Marek Lipert <lipertmj@google.com>

sushilchaskar28 added a commit to sushilchaskar28/magic-modules that referenced this pull request Dec 24, 2025

Update dataset id in Entry.yaml

424feec

This is causing TestAccDataplexEntry_dataplexEntryBigqueryTableExample test failure in GoogleCloudPlatform#16024

c2thorn requested changes Dec 29, 2025

View reviewed changes

mmv1/products/dataplex/Datascan.yaml Show resolved Hide resolved

mmv1/products/dataplex/Datascan.yaml Show resolved Hide resolved

github-actions bot requested a review from c2thorn December 31, 2025 23:08

feat: Implement OneTime trigger for Dataplex Datascan

0f21a7a

sushilchaskar28 force-pushed the oneTime branch from e8ad6ec to 0f21a7a Compare January 5, 2026 23:07

sushilchaskar and others added 2 commits January 5, 2026 19:07

feat: Implement OneTime trigger for Dataplex Datascan

38a1bad

Update resource_dataplex_datascan_test.go

81a1ed7

c2thorn requested changes Jan 6, 2026

View reviewed changes

mmv1/third_party/terraform/services/dataplex/resource_dataplex_datascan_test.go Show resolved Hide resolved

c2thorn requested changes Jan 6, 2026

View reviewed changes

mmv1/products/dataplex/Datascan.yaml Show resolved Hide resolved

Merge branch 'GoogleCloudPlatform:main' into oneTime

fb1efc7

sushilchaskar28 force-pushed the oneTime branch from d5aa6c0 to fb1efc7 Compare January 6, 2026 19:38

github-actions bot requested a review from c2thorn January 6, 2026 19:39

c2thorn approved these changes Jan 6, 2026

View reviewed changes

c2thorn added this pull request to the merge queue Jan 6, 2026

Merged via the queue into GoogleCloudPlatform:main with commit 1a2738b Jan 6, 2026
26 of 27 checks passed

feat: Implement OneTime trigger for Dataplex Datascan #16024

feat: Implement OneTime trigger for Dataplex Datascan #16024

Uh oh!

Conversation

sushilchaskar28 commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 23, 2025

Uh oh!

modular-magician commented Dec 23, 2025

Diff report

Uh oh!

modular-magician commented Dec 23, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 23, 2025

Uh oh!

sushilchaskar28 commented Dec 24, 2025

Uh oh!

sushilchaskar28 commented Dec 24, 2025

Uh oh!

modular-magician commented Dec 24, 2025

Diff report

Uh oh!

modular-magician commented Dec 24, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 24, 2025

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

Uh oh!

Uh oh!

modular-magician commented Dec 31, 2025

Diff report

Uh oh!

modular-magician commented Dec 31, 2025

Tests analytics

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

modular-magician commented Jan 5, 2026

Diff report

Uh oh!

modular-magician commented Jan 5, 2026

Tests analytics

Uh oh!

modular-magician commented Jan 5, 2026

Diff report

Uh oh!

modular-magician commented Jan 5, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 5, 2026

Uh oh!

modular-magician commented Jan 6, 2026

Diff report

Uh oh!

modular-magician commented Jan 6, 2026

Diff report

Uh oh!

modular-magician commented Jan 6, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 6, 2026

Uh oh!

modular-magician commented Jan 6, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 6, 2026

Uh oh!

modular-magician commented Jan 6, 2026

Diff report

Uh oh!

modular-magician commented Jan 6, 2026

sushilchaskar28 commented Dec 23, 2025 •

edited

Loading