Remove post-startup-script key from protected metadata for EUC

[madhusuraj]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

workbench: support setting post-startup script metadata keys with managed EUC for `google_workbench_instance`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[rileykarson]

We did a complete match for WorkbenchInstanceEUCProvidedAdditionalMetadata but are doing a substring match here- could you elaborate on why?

[madhusuraj]

This was just for consistency with the existing WorkbenchInstanceSettableUnmodifiableDefaultMetadata check, changed it to a complete match.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 17 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 1 file changed, 17 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 34 insertions(+), 6 deletions(-))

[modular-magician]

Tests analytics

Total tests: 25
Passed tests: 24
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• workbench

🟢 All tests passed!

View the build log

[github-actions]

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[madhusuraj]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 72 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 72 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 37 insertions(+), 6 deletions(-))

[modular-magician]

Tests analytics

Total tests: 26
Passed tests: 24
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_metadataEUCForceNew

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_metadataEUCForceNew [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 73 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 73 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 37 insertions(+), 6 deletions(-))

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccWorkbenchInstance_metadataEUCForceNew

Tests analytics

Total tests: 26
Passed tests: 24
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• workbench

🟢 All tests passed!

View the build log