Fix for multiple chunks emitting to ssr-bundle.js#51
Fix for multiple chunks emitting to ssr-bundle.js#51dwoznicki wants to merge 1 commit intoGoogleChromeLabs:masterfrom
Conversation
…h {{prerender}} injection injection point fails with:
Error: Conflict: Multiple chunks emit assets to the same filename ssr-bundle.js
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Wow I was about to open a similar PR and developit/microbundle#74 stopped me from making sure it works. anyway- thumbs up! |
Prerendering multiple entries in conjunction with the
{{prerender}}injection point results in the following error:even when an entry is specified in the loader query string for HtmlWebpackPlugin template.
This appears to be caused by this block clobbering the original entry and changing it to
undefined.I'm not sure what the original intention here is, but only reassigning the entry if it's not already set probably fixes the issue. I can't say for sure because I can't build due to developit/microbundle#74. Making this change directly to
dist/prerender-loader.jsworked for me.Fixes #29 (comment)