This repository was archived by the owner on Dec 7, 2022. It is now read-only.
specify support of ShadowRoot#341
Open
valdrinkoshi wants to merge 1 commit intoGoogleChrome:masterfrom
Open
Conversation
Contributor
Author
|
@alice @addyosmani FYI. This is just to have more robust tests 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#338 actually provided support for elements hosted in a shadow root, not a
<template>. This PR makes it more clear & updates the tests accordingly.When an element is hosted in
<template>.content, its.parentNodewill be aDocumentFragment, and the fragment's.hostwill beundefined.When an element is hosted in a
shadowRoot, its.parentNodewill be aDocumentFragment, and the fragment's.hostwill be the shadowRoot owner element 🎉