Conversation
weiji14
left a comment
There was a problem hiding this comment.
Just a few minor comments, otherwise fine.
On a related note, should probably improve the documentation of plot at https://www.pygmt.org/v0.2.0/api/generated/pygmt.Figure.plot.html#pygmt.Figure.plot since it's quite widely used. I was going to do it in #471 but might be better to have a separate PR handling it specifically.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
left a comment
There was a problem hiding this comment.
Ok, good to merge. The macOS test breakages seem unrelated, not sure why there's a segmentation fault on the xarray shading test?
In PR #650, I added more tests for xarray shading. These tests work well for GMT master, but not for 6.1.1. Perhaps some of the tests have segmentation faults with GMT 6.1.1. |
Description of proposed changes
This PR adds the no_clip argument (alias of -N) to plot, text, countour and meca.
The name no_clip was agreed when wrapping the grdimage method in #620 (comment)
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.