-
Notifications
You must be signed in to change notification settings - Fork 235
Standardize parameter ordering in function signature and docstrings for common options #4410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
12
commits into
main
Choose a base branch
from
copilot/list-common-options-alphabetically
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: seisman <3974108+seisman@users.noreply.github.com>
Co-authored-by: seisman <3974108+seisman@users.noreply.github.com>
Co-authored-by: seisman <3974108+seisman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Consistently list common options alphabetically in docstrings
Reorganize common parameters to end of docstrings
Feb 12, 2026
…dview) Co-authored-by: seisman <3974108+seisman@users.noreply.github.com>
…ication Co-authored-by: seisman <3974108+seisman@users.noreply.github.com>
Copilot
AI
changed the title
Reorganize common parameters to end of docstrings
Standardize parameter ordering: uppercase params by spec, lowercase alphabetically by GMT flag
Feb 12, 2026
seisman
reviewed
Feb 12, 2026
seisman
reviewed
Feb 12, 2026
…emap, fix registration ordering in binstats Co-authored-by: seisman <3974108+seisman@users.noreply.github.com>
Co-authored-by: seisman <3974108+seisman@users.noreply.github.com>
Copilot
AI
changed the title
Standardize parameter ordering: uppercase params by spec, lowercase alphabetically by GMT flag
Standardize parameter ordering across all PyGMT functions
Feb 12, 2026
seisman
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
final review call
This PR requires final review and approval from a second reviewer
maintenance
Boring but important stuff for the core devs
skip-changelog
Skip adding Pull Request to changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter ordering was inconsistent across PyGMT functions, with common parameters appearing in different sequences in different files. This created cognitive overhead when navigating the codebase and made the API harder to learn.
Changes
Established canonical ordering:
projection→zscale→zsize→region→frame→verboseUpdated 29 files:
basemap.pykeeps projection/region/frame at start (primary parameters)Example
Before:
After:
All 57 files with common parameters now follow canonical ordering.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.