Use f-string type conversion !r in error messages#4409
Open
Conversation
Co-authored-by: seisman <3974108+seisman@users.noreply.github.com>
Co-authored-by: seisman <3974108+seisman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Use f-string type conversion in error messages
Use f-string !r conversion in error messages
Feb 12, 2026
Convert objects to string before using !r to ensure proper formatting for both regular strings and test objects like FakedLibGMT. Co-authored-by: seisman <3974108+seisman@users.noreply.github.com>
The source code correctly uses !r conversion. Tests needed to be fixed by adding a __repr__ method to FakedLibGMT class so it formats correctly with !r. Co-authored-by: seisman <3974108+seisman@users.noreply.github.com>
Co-authored-by: seisman <3974108+seisman@users.noreply.github.com>
Copilot
AI
changed the title
Use f-string !r conversion in error messages
Use f-string !r type conversion in error messages
Feb 12, 2026
Updated docstring examples in decorators.py and test expectations in test_clib_loading.py to consistently use !r conversion instead of manual quotes. Co-authored-by: seisman <3974108+seisman@users.noreply.github.com>
Copilot
AI
changed the title
Use f-string !r type conversion in error messages
Complete f-string !r conversion in docstrings and test patterns
Feb 12, 2026
seisman
approved these changes
Feb 12, 2026
Member
|
This PR is made by Copilot, and it looks pretty good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated remaining instances of manual quote formatting to use
!rtype conversion for consistency with the rest of the codebase.Changes
pygmt/helpers/decorators.py(2 docstring examples)f"'{k}': {repr(kwargs[k])}"→f"{k!r}: {kwargs[k]!r}"pygmt/tests/test_clib_loading.py(10 test patterns)!rformatrf"Error loading '{var}'"→rf"Error loading {var!r}"Example
This completes the conversion started in earlier commits, ensuring all error messages and test patterns use the more concise
!rsyntax.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.