CI: Use pytest '--override-ini' to override 'addopts' setting in the "Benchmarks" workflow#3620
Merged
CI: Use pytest '--override-ini' to override 'addopts' setting in the "Benchmarks" workflow#3620
Conversation
CodSpeed Performance ReportMerging #3620 will not alter performanceComparing 🎉 Hooray!
|
| Benchmark | main |
ci/benchmarks |
Change | |
|---|---|---|---|---|
| 🆕 | test_virtualfile_from_vectors_one_string_or_object_column[pyarrow] |
N/A | 8.4 ms | N/A |
test_text_multiple_lines_of_text |
14.1 ms | N/A | N/A | |
| 🆕 | test_text_multiple_lines_of_text[list] |
N/A | 14.1 ms | N/A |
| 🆕 | test_text_multiple_lines_of_text[numpy] |
N/A | 14.1 ms | N/A |
| 🆕 | test_text_multiple_lines_of_text[pyarrow] |
N/A | 14.2 ms | N/A |
This reverts commit 7365065.
weiji14
approved these changes
Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
In the benchmarks workflow, we don't care if the generated images are correct or not, so we don't do the image comparisons. Then we see many warnings (first noticed in #2923 but are ignored) like :
I think the warnings mean that the "pytest-mpl" plugin is not activated.
However, with the latest
pytest-codspeedv3.0.0, the Benchmarks workflow suddenly broke (initially reported in #2933 (comment)). Now the workflow fails with errors like:The errors mean that the
pytest-mplplugin is activated now.This PR fixes the issue by using the
--override-inioption to override theaddoptsoption, so that the--mploption is not added automatically.With this PR, the remaining warnings are: