Conversation
This was referenced Oct 30, 2023
seisman
approved these changes
Oct 31, 2023
Member
|
The PR title makes no sense to people who don't know NPY002. Could you please update the PR title to make it more clear what the changes are? |
Member
Author
I have improved the title, added the links to the previews, and expanded the comment explaining this PR. |
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
seisman
reviewed
Oct 31, 2023
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR aims to update the examples to follow ruff's NumPy rules, especially it addresses the
NPY002warning (please see https://docs.astral.sh/ruff/rules/numpy-legacy-random/):Example:
is replaced by
Affected examples:
Please note that the plots are not completely identical. This is because the generated random numbers are not identical.
Related to the PRs
Fixes #2779 partly
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version