Conversation
weiji14
added
documentation
willschlitzer
changed the title
maxrjones
reviewed
Oct 6, 2021
Comment on lines
+72
to
+79
| Read the information pertaining to each Voronoi | ||
| polygon (the unique node lon, lat and polygon area) from a separate | ||
| file [Default acquires this information from the ASCII segment | ||
| headers of the output file]. Required if binary input via `voronoi` | ||
| is used. | ||
| voronoi : str | ||
| Append the name of a file with pre-calculated Voronoi polygons | ||
| [Default performs the Voronoi construction on input data]. |
Member
There was a problem hiding this comment.
Especially one sphtriangulate is wrapped, we will need to open a separate issue to discuss how to pass these data to sphdistance from memory rather than relying on writing/reading files.
seisman
reviewed
Oct 10, 2021
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Member
|
@willschlitzer, would you mind merging main into this branch to fix the vercel preview? |
seisman
reviewed
Oct 25, 2021
seisman
added
final review call
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
michaelgrund
approved these changes
Oct 26, 2021
Contributor
Author
|
@GenericMappingTools/pygmt-admin Could I get one of the admins to merge this? I'm not able to with the failed windows-latest test. |
seisman
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a follow up to #1383, and wraps additional optional parameters for
sphdistance.Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version