Fix psmeca failure when P and T axes have equal dips#8862
Fix psmeca failure when P and T axes have equal dips#8862seisman merged 12 commits intoGenericMappingTools:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the psmeca module where the function failed when the P (pressure) and T (tension) axes have equal dips. The fix modifies the logic in the meca_axe2dc function to properly handle the edge case of equal dips while excluding the strike-slip fault case.
Key changes:
- Enhanced conditional logic to detect when P and T axes have equal dips (within tolerance)
- Added special handling to exclude strike-slip faults where both dips are near zero
- Added explanatory comments documenting the logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joa-quim
left a comment
joa-quim
left a comment
There was a problem hiding this comment.
CI continue a incomprehensible disaster. Run the tests locally and and all seem fine. Two points though:
- We use C comments, not C++ (Copilot invention)
- What about a new test for this case?
|
Looks good. Could you please add a test for it? |
Ok,I'll be careful next time. |
I'll try to add one if I can |
You can still change it for this time. It's just replace the |
|
Could you please also add the focal mechanisms in #8009 into the test? |
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
3 participants
I tried again, however, unlike before, I was able to download the dvc files during this local test, so I used the results from the master branch for the test.
Fixes #8009