Closed
Conversation
- Update test/baseline/seis.dvc with new hashes for full_moment_tensor.ps, meca_-Smdz.ps, and seis_07.ps - Update test/baseline/potential.dvc with new hash for fc_okb.ps - Update test/baseline/grdimage.dvc with new hash for transp_mix.ps
Member
|
Are you sure that your changes in #8821 are correct and the baseline images are worng? Need some time to verify it. |
Member
|
I get no local failures related to psmeca. |
Member
|
The CI jobs on Linux/macOS/Windows fail and I also get the same failures locally. |
Member
Author
|
I'll check and correct it again |
Member
|
I'm seeing the failures now too (probably did not update before). And, for example the |
Member
Author
|
Let me think it seriously. |
1 similar comment
Member
Author
|
Let me think it seriously. |
Member
|
I think we should revert changes in #8821 until we find a working solution. |
Member
|
Yes, agree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix test error
#8821
The test failed, but it works correctly when I test it locally.
@seisman