feat: Add the possibility to map cells for same type meshes but with differents cell dimension #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainBaville
added
flag: ready for review
type: feature
test-geos-integration
RomainBaville
changed the title
paloma-martinez
approved these changes
Dec 1, 2025
Collaborator
paloma-martinez
left a comment
paloma-martinez
left a comment
There was a problem hiding this comment.
Just very small modifications to do, but LGTM other than that
paloma-martinez
approved these changes
Dec 3, 2025
paloma-martinez
deleted the
RomainBaville/feature/AttributeMappingBetween2DAnd3DVTU
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr aims to improve the function computeElementMap by dealing with same type meshes but with differents cell dimension.