Fix failing tests from recent commit #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rustfmt commit exposed an issue where the Quote struct in create-issue was using String for author_url, but fetch-quote was returning Option<String>. Changes: - Updated Quote struct in create-issue to use Option<String> for author_url - Fixed test template to use camelCase field names (authorUrl, authorDescription) instead of snake_case (author_url, author_description) to match serde renames - Removed outdated assertion checking for subscribe_form which was removed from the template in a previous commit All tests now pass.
There was a problem hiding this comment.
Pull Request Overview
This PR makes the author_url field optional in the Quote struct and updates test code to use the correct camelCase field names in Tera templates, aligning with the serde rename attributes.
- Changed
author_urlfield fromStringtoOption<String>with conditional serialization - Updated test templates to use camelCase naming (
authorUrl,authorDescription) instead of snake_case - Removed outdated test assertion and trailing whitespace
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| functions/create-issue/src/model.rs | Made author_url field optional with Option<String> and added skip_serializing_if |
| functions/create-issue/src/template.rs | Updated test code to use camelCase field names, wrapped author_url in Some(), removed outdated assertion, and cleaned up trailing whitespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lmammino
deleted the
claude/fix-failing-tests-011CUvap93jua4x9Mzwaa5La
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rustfmt commit exposed an issue where the Quote struct in create-issue was using String for author_url, but fetch-quote was returning Option.
Changes:
All tests now pass.