Skip to content

Env fix#17

Merged
MichalFrends1 merged 3 commits intomainfrom
env-fix
Feb 4, 2026
Merged

Env fix#17
MichalFrends1 merged 3 commits intomainfrom
env-fix

Conversation

@MatteoDelOmbra
Copy link
Contributor

@MatteoDelOmbra MatteoDelOmbra commented Feb 4, 2026

Please review my changes :)

Summary by CodeRabbit

  • Chores
    • Updated package version to 1.9.0
  • Tests
    • Improved test environment: if a .env file exists it will be copied to test output (preserve newest) to ensure environment variables are available during test runs

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

Walkthrough

Two .csproj files were updated: the test project now copies a local .env file to the test output when present, and the task template's PackageVersion was incremented from 1.8.0 to 1.9.0.

Changes

Cohort / File(s) Summary
Test Configuration
Frends.Echo.Execute.Tests/Frends.Echo.Execute.Tests.csproj
Added a None MSBuild item conditioned on Exists('.env') to copy .env to the test output with CopyToOutputDirectory=PreserveNewest.
Package Version
FrendsTaskTemplate.csproj
Bumped PackageVersion from 1.8.0 to 1.9.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • MichalFrends1

Poem

🐇 I hop a tiny .env near,

so tests can sniff the air with cheer.
Version raised, a gentle climb,
Templates tuned, all snug in time. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Env fix' is vague and generic, using non-specific terminology that doesn't clearly convey what environmental issue is being addressed or fixed. Consider using a more descriptive title such as 'Add conditional .env file inclusion to project' or 'Fix .env file copy configuration' to better communicate the specific change being made.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch env-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In
`@Frends.Template/Frends.Echo.Execute/Frends.Echo.Execute.Tests/Frends.Echo.Execute.Tests.csproj`:
- Around line 12-14: The project currently unconditionally includes ".env" via
the <ItemGroup>/<None Include=".env" CopyToOutputDirectory="PreserveNewest"/>
entry which fails CI when .env is absent and can leak secrets; update the csproj
so the None Include for ".env" is only added when the file exists (use a
Condition like Exists('.env') on the ItemGroup or the None element) or remove
CopyToOutputDirectory for production builds, and instead commit a ".env.example"
for defaults; modify the <None Include=".env"...> entry (and/or its enclosing
<ItemGroup>) so it is conditional on file existence to avoid build failures and
secret leakage.

Add condition to include .env file only if it exists.
@MichalFrends1 MichalFrends1 merged commit 242bfb1 into main Feb 4, 2026
4 checks passed
@MichalFrends1 MichalFrends1 deleted the env-fix branch February 4, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants